Refactor get_port to use FNV-1a hash for consistency across platforms #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
changed the title
|
Confirmed this works! |
|
@deanlee this breaks PlotJuggler streaming, can you make a PR to fix? |
|
Just need to rebuild PJ? |
|
Thanks @deanlee, this makes it easier to derive the same port from other languages! |
|
yea, confirmed PJ is broken. I wasn't even able to build/run PJ before so unsure if it was caused by this PR. |
|
I can't stream either. Last commit from OP stream worked I checked was On the commit prior to this MR, streaming was working 3e17f86 |
That's what it looks like from looking on https://github.com/commaai/PlotJuggler/blob/5dff41cfd5d046711bdcf255665c816852056beb/plotjuggler_plugins/DataStreamCereal/datastream_cereal.cpp#L79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve commaai/openpilot#34031 :
This pr fixes the issue where the
get_portfunction returns different port values on macOS and Linux due to platform-specific behavior ofstd::hash. The mismatch in port values causes connection failures in ZMQ. The solution replacesstd::hashwith a custom FNV-1a hash function to ensure consistent port values across platforms, and reducing the risk of collisions.